Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Don't fail if dir exists #45413

Merged
merged 2 commits into from
May 30, 2024
Merged

fix(files): Don't fail if dir exists #45413

merged 2 commits into from
May 30, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented May 21, 2024 •
edited
Loading

Summary

In some cases, mkdir is returning false because directory already exists on disk (race condition?)
Nevertheless, we shouldn't need to throw if folder exists.

Exception":"OCP\\Files\\NotPermittedException","Message":"Could not create folder \"/appdata_ocwfs52oscxg/preview/5/e/8/b/b/c/e/3685938\

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label May 21, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone May 21, 2024
@solracsf solracsf self-assigned this May 21, 2024
@solracsf solracsf requested review from a team, ArtificialOwl, icewind1991 and yemkareems and removed request for a team May 22, 2024 08:15
@solracsf solracsf requested a review from Altahrim May 22, 2024 15:26
solracsf and others added 2 commits May 30, 2024 14:27
@solracsf @artonge
fix(files): Try to create dir only if it not exists
5c4e4c5 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf @Altahrim @artonge
Try create folder first and check if it exists after
77979b1 
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@artonge artonge force-pushed the createIfNotExists branch from 7420d89 to 77979b1 Compare May 30, 2024 12:27
@susnux susnux merged commit 48e6240 into master May 30, 2024
154 of 155 checks passed
@susnux susnux deleted the createIfNotExists branch May 30, 2024 17:45
@solracsf
Copy link
Member Author

/backport to stable29

@solracsf
Copy link
Member Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request May 30, 2024
Merged
@solracsf solracsf changed the title fix(files): Try to create dir only if it not exists fix(files): Don't fail if dir exists May 30, 2024
@backportbot backportbot bot mentioned this pull request May 30, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@vitormattos vitormattos mentioned this pull request Jul 18, 2024
Closed
4 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees

@solracsf solracsf

Labels
3. to review Waiting for reviews feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@solracsf @Altahrim @artonge @susnux